Code Review — PR #910: Dashboard Friday-morning update

Summary: Docs-only update to RELEASE-READINESS.html refreshing the release dashboard from Thursday EOD state to Friday morning. No code changes — purely a status document update.

What this PR does

• Updates header date/subtitle to Friday 2026-06-12 AM
• Decrements the countdown from 2 → 1 day (ship target: Sat 2026-06-13)
• Updates gates 8 and 9 status text to reflect today's work items
• Refreshes the verdict/narrative to note Thursday's two detail-page bugs (Fix Neovim Terminal detail page rendering the Home Row Mods editor #903, Fix Neovim Terminal detail sheet clipping (add to wide-pack width list) #908) landed on master
• Updates the weekly calendar label from "Next" → "Today" for Friday
• Decrements the system key family count from 2 → 1

Observations

Accurate and well-referenced:

• The countdown (2→1) is correct for a Saturday ship target.
• Fix Neovim Terminal detail page rendering the Home Row Mods editor #903 and Fix Neovim Terminal detail sheet clipping (add to wide-pack width list) #908 are confirmed merged (2026-06-11), so crediting them is accurate.
• "Next" → "Today" label is correct since today is 2026-06-12.
• The narrative change is cleaner — focused on what's left rather than what was done.

One item to verify:
The system key family count goes from 2 → 1 in the Families by UI category section. PR #899 (cmd-removal) is still open, and the verdict text in this very diff says "the cmd-removal PR #899 is the other workstream's to merge." If this count decrement reflects the cmd family being removed, it's premature — the dashboard would show a state that isn't yet on master.

Please confirm: is this count driven by already-landed catalog.json changes independent of #899, or is it tracking #899's merge? If the latter, revert to 2 until #899 merges.

Minor nit:
Gate 8 pill reads "drafted · today" — the middle-dot separator is slightly inconsistent with other pill labels ("closed early", "nearly closed"), but harmless for a status doc.

Verdict

Clean docs-only PR with accurate status. The system count change is the one item worth a double-check before merging. If that count already reflects landed catalog work independent of #899, this is good to go. Otherwise, hold that one line until #899 merges.

Code Review — PR #910: Dashboard Friday-morning update

Type: Docs-only (RELEASE-READINESS.html, 11 additions / 11 deletions)

Overview

Routine status refresh of the release readiness dashboard for Friday 2026-06-12 AM. Updates the subtitle, countdown, gate 8/9 descriptions, verdict narrative, weekly schedule labels, and the "system" family count stat. No logic or source-code changes.

Findings

Minor: Date staleness on merge

The PR was authored for Friday 2026-06-12, but today is already Saturday 2026-06-13 (ship day). If merged now, the dashboard will be immediately stale in two places:

• <span class="now-tag">Today</span> on the Friday row will misidentify Friday as the current day.
• <span class="num">1</span> days to ship Sat 2026-06-13 should now read 0 (or "Ship day").

If the intent is to merge this as a historical snapshot, that's fine — just worth noting. If the dashboard is still being actively consulted, a quick follow-up to flip Friday to "done" and Saturday to "Today" / 0 days would keep it accurate.

Minor: "system" family count 2 → 3 is asserted but not sourced

The stat section carries the comment "canonical from catalog.json". The HTML is updated but there's no corresponding diff to catalog.json (or wherever it is generated from). If the count change is real it should be reconciled in the source; if it's a manual edit it should be noted so it doesn't get overwritten on the next regeneration.

What's Good

• Compact, surgical diff — exactly the cells that changed, nothing else.
• PR Fix Neovim Terminal detail page rendering the Home Row Mods editor #903 and Fix Neovim Terminal detail sheet clipping (add to wide-pack width list) #908 are now cited in gate 9, giving reviewers traceability to the overnight fixes.
• "cmd-removal PR Remove the cmd capability end-to-end: engine feature flag + #874 app machinery #899" is explicitly called out as another workstream's to merge, avoiding ambiguity.
• "Next" → "Today" label swap is correct for the intended Friday-morning timestamp.

Verdict

Approve with one nit: the date staleness is cosmetic and expected given the static-HTML format; the catalog count discrepancy is the only thing worth a second look before merge. Both are low-risk for a docs-only change.

Code review posted below.

Code Review: PR 910 — Dashboard: Friday-morning release-readiness state

Overview: Pure docs-only change updating RELEASE-READINESS.html to reflect Saturday as release day: advancing gate counts, flipping day-of-week markers, and updating the verdict/schedule blurb.

Issue 1 — PR title and body do not match the diff. Title says 'Friday-morning' and body says '6 of 10 gates closed', but the diff reflects Saturday 2026-06-13 as release day with 8 gates done. The PR was likely authored Friday and updated before opening without refreshing the metadata. Minor, but creates a confusing historical record.

Issue 2 — RELEASE-READINESS.md not updated. The HTML dashboard has a 'View markdown source' link pointing to RELEASE-READINESS.md, which exists in the repo. Only the .html file changed in this PR. If the two files are meant to stay in sync, the .md file needs the same factual updates.

Issue 3 — System-category count bump (2 to 3) is unexplained. Around line 655, the system family count bumps from 2 to 3 with no mention in the PR body. If a new system pack shipped (e.g. via cmd-removal hardening in PR 899), a one-line note would make the change legible.

Issue 4 — Inline style on gate 7 row is inconsistent. Gate 7 gets a hardcoded background color via an inline style on its tr element. No other wip rows use this pattern. A shared CSS class (.row-active) would be cleaner if this pattern recurs. Low priority for a short-lived dashboard.

What is correct:

• Countdown from 2 to 0 is right for release day.
• Gate 9 moving to done (screenshots stripped, gh-pages publish deferred to ship step) is consistent with PRs 921/920 merging.
• Thursday and Friday flipping to .day.done, Saturday becoming .day.today — structurally correct.
• Gate 8 release-notes qualification language (QMK fully tested; Karabiner basic-remaps only, fidelity gaps noted) matches the PR body.
• Docs-only change; no code logic; tests not applicable.

Verdict: Approve with minor notes. Content is directionally accurate and the HTML is structurally sound. Main actionable items: (a) sync RELEASE-READINESS.md if it is meant to track the HTML, and (b) explain the system-category count bump in the PR body. The title/body staleness is cosmetic.

Thanks — addressed the review findings in the Saturday commits (07badcaa2, 82e94876c):

• Date staleness (both reviewers): dashboard is now release-day current — countdown 0 / ship TODAY, Thu+Fri flipped to .day.done, Sat is .day.today with the Now tag, and the burn-down now plots actual through Saturday (the leftover Thu ◀ marker + Fri/Sat projection are gone; Sat is the current marker at the floor). Footer timestamp Wed → Sat 2026-06-13.
• system category count (Codex P2 + Claude): reconciled to 3 (macOS Function Keys, Leader Key, Fast Navigation) so the breakdown sums to 22. This is a hand-maintained dashboard, not generated from catalog.json — I dropped the overclaimed "auto-synced" footer wording so the count won't read as machine-sourced. Already replied on the inline thread.
• RELEASE-READINESS.md not in sync: the HTML is the live artifact being consulted; the .md is the source gate checklist. Footer now says "Companion to RELEASE-READINESS.md · Maintained by hand" rather than claiming auto-sync.
• Gate-7 inline tr style / title-body staleness: acknowledged, left as-is — this is a short-lived release-week dashboard and the pattern doesn't recur.

Substance is current; remaining notes are cosmetic.

Code Review — PR #910: Dashboard Friday-morning release-readiness state

Overview

Docs-only PR updating RELEASE-READINESS.html to reflect Saturday release-day status: 8 of 10 gates closed, RC cutting in progress, burndown chart actuals extended through Friday, and the week-view day cards advanced.

Issues

PR title/description doesn't match the content (significant)

The PR title says "Friday-morning release-readiness state" and the description says "6 of 10 gates closed", but the actual HTML content reflects Saturday 2026-06-13 (release day) with 8 of 10 gates closed. Either:

• The title/description were written Thursday/Friday and never updated before opening, or
• The content was updated after the PR was already written

This matters because the PR description is the audit trail. Anyone reviewing the git history will see a commit message/PR body that contradicts what actually changed. Please update the PR title to something like Dashboard: Saturday release-day state and align the body with what's in the diff.

Observations

Burndown chart SVG — Clean refactor: the projected (dashed blue) line and dots are removed, actual (green) is extended through Sat with cx=250 cy=120 representing ~3h remaining. That correctly avoids claiming "zero hours left" when RC + smoke + publish are still in flight. The legend removal of the "projected" entry is consistent. No visual/math issues spotted.

Gate 9 status flip — Changed from wip / nearly closed → done / closed, consistent with referenced PRs #921/#920. Makes sense.

Gate 7 — Highlighted row (background: rgba(95,168,255,0.06)) to call attention to the in-progress RC is a nice touch.

System count (2→3) — Single number change in the UI-category bar chart. If this reflects a new family added in a separately merged PR, it's correct. Worth a quick sanity check that it matches the actual catalog.json count.

Footer — Updated from "Wed 2026-06-10" to "Sat 2026-06-13". Correct.

Summary

The HTML content changes are accurate and internally consistent. The only actionable issue is the PR title and description being stale relative to the actual Saturday content — fix those before merging so the git history reflects what actually shipped. Everything else is a clean status update with no logic or code risks.

Fixed the actionable item: PR title → Dashboard: Saturday release-day state and body aligned to 8 of 10 gates / Saturday release-day content, so the audit trail matches the diff. Thanks for the burndown-refactor sanity check (the cx=250 cy=120 ~3h-remaining read is intended — avoids claiming zero while RC + smoke + publish are still in flight). System count = 3 confirmed against the inventory table (sums to 22).

Code Review — PR #910: Dashboard Saturday release-day state

Docs-only change, single file (RELEASE-READINESS.html). Low risk.

Overview

This PR advances the release-readiness dashboard from the Thursday/2-days-out state to the Saturday release-day snapshot: countdown → 0, gates 6→8 closed, burndown projection replaced by actuals through Saturday, and the schedule strip advanced. It's a coherent, well-maintained snapshot of the release-day status.

What looks good

• SVG burndown math is correct. The scale is 3.33px/hr (120px span / 36h range). New Saturday endpoint at cy="120" = 3h remaining → exactly right. All intermediate actual points (96.7, 113.3) are mathematically consistent with the prior days' actual hours.
• Legend cleanup is complete. Removing the blue "projected" line also removed its legend entry — no orphaned legend items remain.
• Gate 7 row highlight (background: rgba(95,168,255,0.06)) correctly distinguishes the in-flight RC gate from the others. Consistent with how "wip" gates look elsewhere.
• Footer text correction from "Auto-synced from RELEASE-READINESS.md" to "Maintained by hand" is more honest and eliminates a false promise about automation.
• System family count 2→3 matches the PR description (macOS Function Keys, Leader Key, Fast Navigation = 3). Good catch on the overcounted value.

Minor observations

1. Gate 10 still says scheduled — accurate per the PR description (video may trail to Sunday). No change needed, just confirming this was intentional and not forgotten.

2. Burndown SVG comment updated correctly: the old Projection at ~22 available hrs stale text is gone; the new comment accurately describes actuals through Saturday. Good hygiene — stale SVG comments are easy to miss.

3. PR opened as a snapshot, not yet merged ("Will merge after the 1.0.0 ship") — the PR description is clear about this. Worth confirming the merge happens post-ship so the dashboard captures the true final state rather than the mid-RC state.

No issues found

No code correctness concerns (static HTML/SVG), no security surface, no test coverage needed. All content changes are internally consistent and match the PR description.

Approved. Merge after the ship.